refactor: remove all receiver references to bundled config host files #229
Conversation
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
|
I think this does drive the host monitoring app's resource dataset which customers have complained about breaking before |
obs-gh-mattcotter
force-pushed
the
OB-42646-deprecate-filestats
branch
from
bceb622 to
4f27277
Compare
obs-gh-mattcotter
force-pushed
the
OB-42646-deprecate-filestats
branch
from
4f27277 to
088e3d2
Compare
obs-gh-mattcotter
changed the title
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-mattcotter
force-pushed
the
OB-42646-deprecate-filestats
branch
from
088e3d2 to
78f61a0
Compare
Good point! I put this receiver back and directed it at the agent config. I tested this locally with the otel app and it does work; it successfully tracks the host as a resource. |
| @@ -160,7 +152,7 @@ receivers: | |||
| storage: file_storage | |||
| filestats/agent: | |||
| collection_interval: 5m | |||
| include: /etc/observe-agent/connections/common/base.yaml.tmpl | |||
| include: /etc/observe-agent/observe-agent.yaml | |||
There was a problem hiding this comment.
this should always exist right? unless the user for some reason manually deletes it after install
There was a problem hiding this comment.
This is the expanded env var, so the receiver isn't tied to this path specifically. There is a weird way that you can run the agent with no observe agent config file:
- install
- delete the config at the default path
- start the agent using env var overrides for the required fields
but I think that's pretty unlikely and if anyone is doing that, then it's possible that their current app is broken anyway.
Description
OB-42646 Remove all receiver references to bundled config fragments. These files are going away in favor of adding them to the agent binary.